Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition Lean binaries into reasonably-sized shared libraries #466

Closed
Kha opened this issue May 15, 2021 · 1 comment · Fixed by #555
Closed

Partition Lean binaries into reasonably-sized shared libraries #466

Kha opened this issue May 15, 2021 · 1 comment · Fixed by #555

Comments

@Kha
Copy link
Member

Kha commented May 15, 2021

We currently link lean and leanpkg statically (as much as possible), which makes for very simple distribution. Interestingly, we can still dlsym symbols from these executables for use in the interpreter, but this does come with some caveats on specific platforms. Additionally, we are regularly hitting the maximum number of symbols exportable from a Windows DLL/PE (2^16). If we want to keep all (relevant) symbols reachable from the interpreter, we should partition the Lean & C++ code into reasonably-sized shared libraries, which will also reduce code duplication between lean and leanpkg (and potential future executables).

@leodemoura
Copy link
Member

Let's do this one after we refactor the compiler and delete some of the old C++ code.

leodemoura added a commit that referenced this issue Jun 7, 2021
This is a workaround to minimize the number of exported symbols.
See issues #466 and PR #515
leodemoura added a commit that referenced this issue Jun 7, 2021
This is a workaround to minimize the number of exported symbols in the
Lean executable.
See issues #466 and PR #515
@Kha Kha closed this as completed in #555 Aug 18, 2021
ChrisHughes24 pushed a commit to ChrisHughes24/lean4 that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants