Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include won't include strict implicits #5126

Closed
semorrison opened this issue Aug 22, 2024 · 1 comment
Closed

include won't include strict implicits #5126

semorrison opened this issue Aug 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@semorrison
Copy link
Collaborator

Description

include now refuses to include strict implicit section variables.

Context

I ran into this on Mathlib's nightly-testing branch moving to nightly-2024-08-22 , in Mathlib/Analysis/Complex/TaylorSeries.lean.

Steps to Reproduce

section
variable {i : Nat}

include i in -- Works
example : True := by
  have _ := i
  trivial

end

section
variable ⦃i : Nat⦄

include i in -- Fails with "invalid 'include', variable 'i' has not been declared in the current scope"
example : True := by
  have _ := i
  trivial

end

Versions

nightly-2024-08-22, was working fine on nightly-2024-08-21

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

@semorrison semorrison added the bug Something isn't working label Aug 22, 2024
@Kha
Copy link
Member

Kha commented Aug 29, 2024

Was fixed by #5138

@Kha Kha closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants