Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back .olean version check #632

Open
Kha opened this issue Aug 17, 2021 · 0 comments
Open

Bring back .olean version check #632

Kha opened this issue Aug 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Kha
Copy link
Member

Kha commented Aug 17, 2021

We should add back the Lean 3 behavior of writing the Lean binary's commit hash into each .olean file and checking against it on load, optionally omitting the check during development.

However, Lean 4 introduces a new complication here: if we compile only up to stage 1, we use a stdlib compiled by stage 0 (whose hash we set to 00... to avoid rebuilds). So the check would fail. We would either need a new flag for overriding the commit hash while building, or always build up to stage 2. If we default the check to off for development, we could do so only for (nightly/stable) release builds, in which case the overhead of building stage 2 shouldn't matter.

@Kha Kha added the enhancement New feature or request label Aug 17, 2021
ChrisHughes24 pushed a commit to ChrisHughes24/lean4 that referenced this issue Dec 2, 2022
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant