Auto-group syntax parsers where necessary
#1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
commented
Jun 18, 2022
| @@ -54,7 +54,7 @@ macro "left" : conv => `(lhs) | |||
| macro "right" : conv => `(rhs) | |||
| macro "intro " xs:(colGt ident)* : conv => `(ext $xs*) | |||
|
|
|||
| syntax enterArg := ident <|> group("@"? num) | |||
| syntax enterArg := ident <|> ("@"? num) | |||
There was a problem hiding this comment.
This is a separate pitfall: <|> is an operator on two stx, not stx+. I think we would need to change all occurrences of stx+ to sepBy1(stx+, " <|> ") to fix this.
Kha
commented
Jun 18, 2022
Comment on lines
+180
to
+182
| -- as usual, we assume that people using `Parser` know what they are doing | ||
| let stackSz := 1 |
There was a problem hiding this comment.
Will be resolved when we parameterize Parser with stackSz... :)
leodemoura
approved these changes
Jun 27, 2022
This was referenced Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.