feat: user widgets #1238
Merged
feat: user widgets #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vtec234
reviewed
Jun 22, 2022
Vtec234
reviewed
Jun 22, 2022
Vtec234
reviewed
Jun 22, 2022
EdAyers
commented
Jun 23, 2022
3 tasks
This was referenced Jun 24, 2022
gebner
reviewed
Jun 27, 2022
EdAyers
added a commit
to Vtec234/lean4
that referenced
this pull request
Jul 12, 2022
EdAyers
added a commit
to Vtec234/vscode-lean4
that referenced
this pull request
Jul 12, 2022
EdAyers
added a commit
to Vtec234/lean4
that referenced
this pull request
Jul 12, 2022
Vtec234
reviewed
Jul 14, 2022
Vtec234
reviewed
Jul 15, 2022
gebner
reviewed
Jul 15, 2022
gebner
reviewed
Jul 18, 2022
Vtec234
pushed a commit
to Vtec234/lean4
that referenced
this pull request
Jul 19, 2022
Vtec234
reviewed
Jul 19, 2022
|
Ok, I think this is good to go! |
|
The PR description still has several TODOs. Should it be updated? Or are they meant as future work? |
|
Yeah the remaining todos are cyclic dependencies, I'll make issues for them. |
Kha
reviewed
Jul 20, 2022
Kha
reviewed
Jul 20, 2022
Kha
approved these changes
Jul 20, 2022
also rm hash field from UserWidgetInfo because it can be computed in handler instead.
[skip ci]
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
EdAyers
added a commit
to Vtec234/vscode-lean4
that referenced
this pull request
Jul 20, 2022
…tion name instead of WidgetSource This means that the environment extension is not storing a big text object and instead the text is retrieved from the declaration itself.
|
Happy to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also
Todo:
ToJson Syntax? Means that we can passUserWidgetInfodirectly to infoview. → removed@lean4/infoviewon npm Publish @lean4/infoview to npm vscode-lean4#203