Fix empty snapshot list server errors #1259
Conversation
| -- Ignore exceptions, we are only interested in the successful snapshots | ||
| let (cmdSnaps, _) ← oldDoc.cmdSnaps.updateFinishedPrefix |
There was a problem hiding this comment.
A coincidental simplification, but it seems reasonable to ignore errors from the old document. This subsumes the "Internal server error" from above.
There was a problem hiding this comment.
Should we still have the check for aborted here? It's basically just an assertion to make sure we don't violate assumptions internally.
There was a problem hiding this comment.
I don't know, does the assertion have any bearing on the surrounding code? As the comment says, all we're here for is recycling snapshots before the old document gets dumped.
There was a problem hiding this comment.
No, it is a "non-local" check which verifies that a totally different part of the code behaves correctly. Maybe this isn't great practice so makes sense to leave out.
|
@Kha I am merging this PR as-is. My system became unusable today because of the panic error messages. It was happening every time I opened Emacs and then |
It looks like I didn't properly review the
updateFinishedPrefixuses