refactor: replace ignoreLevelMVarDepth by levelAssignDepth
#1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
force-pushed
the
levelmvarassigndepth
branch
4 times, most recently
from
0a7b0f0
to
5daccbd
Compare
leodemoura
reviewed
Dec 19, 2022
gebner
force-pushed
the
levelmvarassigndepth
branch
from
5daccbd
to
ce032d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "global"
ignoreLevelMVarDepthoption that allows assignment of level mvars at any depth, by a much more restrictedlevelAssignDepthfield in the metavariable context, which only allows assignment of level mvars at depth greater or equal tolevelAssignDepth. ThewithNewMCtxDepthis function gets an extra argument to opt-in to allowing level mvars from the outer scope to be assigned. This API is enough for TC synthesis to work just like it does now.Fixes #1951.