Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bool.asProp for coercions #2060

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use Bool.asProp for coercions #2060

wants to merge 4 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Jan 24, 2023

Fixes #2043.

Without this change, we would not inline anything inside
let x_42 := casesOn x_3 fun .. => ... here ...
} else {
return e;
return visit_cases_default(e);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, we would not inline anything inside

let x_42 := Foo.casesOn x_3
  fun .. => ... here ...

@gebner
Copy link
Member Author

gebner commented Jan 24, 2023

@gebner
Copy link
Member Author

gebner commented Jan 24, 2023

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 8b21496.
There were significant changes against commit 345aa6f:

  Benchmark          Metric         Change
  ====================================================
+ qsort              task-clock      -1.4%   (-17.5 σ)
+ qsort              wall-clock      -1.4%   (-17.6 σ)
+ stdlib             instructions    -2.1% (-2365.0 σ)
- stdlib             maxrss           1.1%    (19.7 σ)
+ stdlib             task-clock      -2.5%   (-38.5 σ)
+ stdlib             wall-clock      -2.9%  (-392.4 σ)
- stdlib size        bytes .olean     1.7%
- workspaceSymbols   maxrss           1.1%    (15.4 σ)
+ workspaceSymbols   task-clock      -2.1%   (-10.0 σ)
+ workspaceSymbols   wall-clock      -2.1%   (-10.1 σ)

@fgdorais
Copy link
Contributor

fgdorais commented Feb 3, 2023

I really like this but please post something on Zulip when merging since this looks like some significant update changes. A few quick hints might help too. Please remember that mathlib is not the only thing downstream 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Implement Boolean-to-Prop coercion using Bool.asProp
3 participants