Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore implDetail hyps in withLocation #2219

Conversation

JLimperg
Copy link
Contributor

As reported on Zulip, the MWE

theorem a_lemma : 1 = 2 := sorry

example : 1 = 3 -> 1 = 3 := by
  intro h
  rewrite [a_lemma] at *

would produce the goal

_example: 2 = 32 = 3
h: 2 = 32 = 3

since rewrite also applied to the implementation detail hypothesis _example. This PR makes the withLocation combinator, which rewrite uses to process the at * syntax, ignore implementation detail hypotheses.

@leodemoura leodemoura merged commit c846900 into leanprover:master May 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants