fix: FFI signature mismatches #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bollu Could you please review the LLVM changes? |
Kha
commented
Aug 18, 2023
Kha
commented
Aug 18, 2023
|
I forgot to mention: |
|
I wonder, is it possible for us to have some sort of linter that catches this type of stuff? So something that computes the C type (this should be the easy part as we already kind of do it) and checks if it matches with the actual extern type (this is the part that idk how to do) |
bollu
reviewed
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/wasm.20build.20signature.20mismatch