Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore "fix: make sure refine preserves pre-existing natural mvars (#2435)" #2493

Closed
wants to merge 1 commit into from
Closed

Restore "fix: make sure refine preserves pre-existing natural mvars (#2435)" #2493

wants to merge 1 commit into from

Conversation

thorimur
Copy link
Contributor

This reverts commit a7efe5b.

Fixes #2434.

@github-actions
Copy link
Contributor

Thanks for your contribution! Please make sure to follow our Commit Convention.

@semorrison semorrison added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Aug 31, 2023
@thorimur thorimur closed this Sep 3, 2023
@thorimur
Copy link
Contributor Author

thorimur commented Sep 3, 2023 •
edited
Loading

Note that this draft PR was made irrelevant by #2502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison semorrison will be requested when the pull request is marked ready for review semorrison is a code owner

Assignees
No one assigned
Labels
awaiting-mathlib We should not merge this until we have a successful Mathlib build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: refine loses track of natural goals
2 participants
@thorimur @semorrison