Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LAKE_PKG_URL_MAP #2709

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: LAKE_PKG_URL_MAP #2709

merged 1 commit into from
Oct 25, 2023

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Oct 18, 2023

Initial prototype. Overrides are of the form: LAKE_PKG_URL_MAP={"pkg-name": "git-url", ...}.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 18, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 18, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 19, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Oct 19, 2023

@tydeu tydeu marked this pull request as ready for review October 19, 2023 17:11
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 19, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 23, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Oct 23, 2023
@tydeu
Copy link
Member Author

tydeu commented Oct 23, 2023

@semorrison Is the mathlib CI broken on Lean master? All I did was rebase the PR onto master and it switched from builds-mathlib to breaks-mathlib.

@semorrison
Copy link
Collaborator

Sorry, combined Mathlib/Lean CI is really struggling at the moment, due to the number of simultaneous breaking changes we have going.

Since we previously got a green tick, let's decide to ignore subsequent failures.

@semorrison semorrison removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 24, 2023
@tydeu tydeu merged commit 170fd84 into leanprover:master Oct 25, 2023
16 checks passed
@tydeu tydeu deleted the lake-package-url-map branch October 25, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants