Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't pack ._ files on MacOS #2743

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

digama0
Copy link
Collaborator

@digama0 digama0 commented Oct 24, 2023

Fixes #2742. This needs to be tested on MacOS; this fix is based on https://stackoverflow.com/questions/8766730/tar-command-in-mac-os-x-adding-hidden-files-why .

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 24, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 24, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 24, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@semorrison semorrison removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 24, 2023
@semorrison
Copy link
Collaborator

Checked locally by upload to ProofWidgets from macos, and downloading the zip to linux. Looks good!

@semorrison semorrison merged commit eaf8560 into leanprover:master Oct 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lake upload run on macOS produced a tar with fake .oleans beginning with ._
3 participants