doc: Improve docstrings around Array.mk,.data,.toList #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 26, 2023
|
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
On Zulip there was some disagreement which function should be recommended to be used, without conclusion. To not have this PR (which makes no such recommendation either way) sitting around for much longer, I’ll merge it if noone complains. Further improvements are still possible of course. |
digama0
reviewed
Nov 29, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
@digama0 do you overall agree with these changes? |
|
Regarding the main question, my opinion is as mentioned on zulip - we should rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following a discussion at
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Understanding.20the.20docstring.20for.20docs.23Array.2Edata/near/398705430