fix: lake: whitelist loaded config olean env exts #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 16, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
|
@Kha I requested your review simply for a quick sanity check since the olean code is still a bit of a hack and thus finicky. I don't think there any major questions here. |
Kha
reviewed
Nov 17, 2023
Kha
reviewed
Nov 17, 2023
Kha
reviewed
Nov 17, 2023
tydeu
force-pushed
the
lake/envext-whitelist
branch
2 times, most recently
from
38d6c23
to
9568599
Compare
tydeu
force-pushed
the
lake/envext-whitelist
branch
from
9568599
to
83cbafd
Compare
3 tasks
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2632. Supersedes #2836.
Loads only the Lake attributes, docstrings, and IR from the configuration olean.