feat: detail error message about invalid mutual blocks #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Please make sure to follow our Commit Convention. |
github-actions
bot
added
the
toolchain-available
|
|
@odanoburu are you ready for this to be reviewed? It’s still marked as a draft and no The change looks good; it would be good to have a test file that exercises this. Do you want to do that? |
odanoburu
changed the title
Detail error message to prevent user confusion as in this [Zulip message](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Matching.20on.20prop/near/341456011). Instead of just saying ‘invalid mutual block’, explain what a mutual block may contain.
|
Oh, that’s annoying. I got notifications from github about the new commit, but not that this PR was actually un-drafted. Glad I looked :-) |
nomeata
approved these changes
Dec 5, 2023
|
I should have left a message, but I feared my rebasing and force-pushing and title changing had already produced too much noise. Sorry about that! |
|
Not at all your fault, no worries. This is just me getting used to the reviewer side of the workflow. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent user confusion as in this Zulip message