Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic in leanPosToLspPos #3071

Merged
merged 5 commits into from
Dec 16, 2023
Merged

fix: don't panic in leanPosToLspPos #3071

merged 5 commits into from
Dec 16, 2023

Conversation

semorrison
Copy link
Collaborator

Testing a problem in the REPL.

@semorrison semorrison added the WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. label Dec 14, 2023
@semorrison semorrison changed the title draft: don't panic in leanPosToLspPos fix: don't panic in leanPosToLspPos Dec 14, 2023
@Kha
Copy link
Member

Kha commented Dec 14, 2023

Please use the same defaulting as in the function above it

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 14, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

  • ❗ Mathlib CI will not be attempted unless you rebase your PR onto the 'nightly' branch. (2023-12-14 23:18:51)

@semorrison semorrison marked this pull request as ready for review December 15, 2023 04:03
@semorrison semorrison added awaiting-review Waiting for someone to review the PR and removed WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. labels Dec 15, 2023
mhuisi
mhuisi approved these changes Dec 15, 2023
View reviewed changes
src/Lean/Data/Lsp/Utf16.lean Outdated Show resolved Hide resolved
semorrison added a commit to leanprover-community/repl that referenced this pull request Dec 16, 2023
@semorrison
experiment: use toolchain for leanprover/lean4#3071
162a5cf
@semorrison semorrison added the will-merge-soon …unless someone speaks up label Dec 16, 2023
@semorrison semorrison added this pull request to the merge queue Dec 16, 2023
Merged via the queue into master with commit 4497aba Dec 16, 2023
19 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuisi mhuisi mhuisi approved these changes

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @Kha @leanprover-community-mathlib4-bot @mhuisi