Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upstream Std.Tactic.NoMatch #3279

Closed
wants to merge 1 commit into from
Closed

chore: upstream Std.Tactic.NoMatch #3279

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Collaborator

Another one with some remaining work:

  • Make the tactics builtins
  • Perhaps more of NoMatch.lean can be moved to other files?

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 8, 2024 03:56 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 8, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. (2024-02-08 04:01:10)

@semorrison semorrison added the awaiting-author Waiting for PR author to address issues label Feb 8, 2024
@leodemoura leodemoura mentioned this pull request Feb 8, 2024
Merged
@leodemoura
Copy link
Member

@semorrison Working on it. Going to rebase it on top of #3285

leodemoura added a commit that referenced this pull request Feb 9, 2024
@leodemoura
feat: nofun tactic and term
2b93e7d 
closes #3279
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2024
@leodemoura @semorrison
feat: nary nomatch (#3285)
1f54722 
Base for #3279

---------

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@semorrison
Copy link
Collaborator Author

Replaced by #3286.

@semorrison semorrison closed this Feb 9, 2024
semorrison pushed a commit that referenced this pull request Feb 9, 2024
@leodemoura @semorrison
feat: nofun tactic and term
8aff560 
closes #3279
semorrison pushed a commit that referenced this pull request Feb 9, 2024
@leodemoura @semorrison
feat: nofun tactic and term
9c160b8 
closes #3279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura

@Kha Kha Awaiting requested review from Kha

Assignees

@leodemoura leodemoura

Labels
awaiting-author Waiting for PR author to address issues toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @leanprover-community-mathlib4-bot @leodemoura