Preserve token parse errors #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
commented
Mar 14, 2021
Comment on lines
+1809
to
+1813
| if s.hasError then | ||
| -- Discard token parse errors and break the trailing loop instead. | ||
| -- The error will be flagged when the next leading position is parsed, unless the token | ||
| -- is in fact valid there (e.g. EOI at command level, no-longer forbidden token) | ||
| return s.restore iniSz iniPos |
There was a problem hiding this comment.
@leodemoura This was the critical condition that took me a while to figure out
Kha
commented
Mar 14, 2021
| @@ -11,7 +11,7 @@ namespace Parser | |||
|
|
|||
| namespace Command | |||
| def commentBody : Parser := | |||
| { fn := rawFn (finishCommentBlock 1) true } | |||
| { fn := rawFn (fun c s => finishCommentBlock s.pos 1 c s) (trailingWs := true) } | |||
There was a problem hiding this comment.
Not exactly the start position of the comment, but close enough
Kha
commented
Mar 14, 2021
| else | ||
| let curr := input.get i | ||
| let s := s.setPos (input.next i) | ||
| if curr == '\"' then | ||
| let s := mkNodeToken interpolatedStrLitKind startPos c s | ||
| s.mkNode interpolatedStrKind stackSize | ||
| else if curr == '\\' then | ||
| let s := s.next c.input i |
There was a problem hiding this comment.
@leodemoura I have no idea how this was working until now :)
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
…er#347) Now that leanprover@cdb855d has landed, `initialize` statements can get real docstrings, and we no longer need to silence the linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.