feat: MatcherApp.transform: Try to preserve alt’s variable name #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes the ugly `fst`/`snd` variable names in the functional induction principles go away. Ironically I thought in order to fix these name, I should touch the mutual/n-ary argument packing code used for well-founded recursion, and embarked on a big refactor/rewrite of that code, only to find that at least this particular instance of the issue was somewhere else. Hence breaking this into its own PR; the refactoring will follow (and will also improve some other variable names.)
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Merged
nomeata
commented
Mar 6, 2024
nomeata
added a commit
that referenced
this pull request
Mar 10, 2024
this makes the ugly `fst`/`snd` variable names in the functional induction principles go away. Ironically I thought in order to fix these name, I should touch the mutual/n-ary argument packing code used for well-founded recursion, and embarked on a big refactor/rewrite of that code, only to find that at least this particular instance of the issue was somewhere else. Hence breaking this into its own PR; the refactoring will follow (and will also improve some other variable names.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the ugly
fst/sndvariable names in the functionalinduction principles go away.
Ironically I thought in order to fix these name, I should touch the
mutual/n-ary argument packing code used for well-founded recursion, and
embarked on a big refactor/rewrite of that code, only to find that at
least this particular instance of the issue was somewhere else. Hence
breaking this into its own PR; the refactoring will follow (and will
also improve some other variable names.)