Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fold raw Nat literals at dsimp #3624

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: fold raw Nat literals at dsimp #3624

merged 1 commit into from
Mar 6, 2024

Conversation

leodemoura
Copy link
Member

closes #2916

Remark: this PR also renames Expr.natLit? ==> Expr.rawNatLit?.
Motivation: consistent naming convention: Expr.isRawNatLit.

@leodemoura
fix: fold raw Nat literals at dsimp
d82844a 
closes #2916

Remark: this PR also renames `Expr.natLit?` ==> `Expr.rawNatLit?`.
Motivation: consistent naming convention: `Expr.isRawNatLit`.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 6, 2024 18:26 Inactive
@leodemoura leodemoura added this pull request to the merge queue Mar 6, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0072d13bd40aef791090d1e3e964413f1176162e --onto ae492265fec103aa834d897bf9f68c94d10f0785. (2024-03-06 18:31:28)

Merged via the queue into master with commit 5302b78 Mar 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dsimp doesn't pack raw nat_lits into OfNat.ofNat invocations
2 participants
@leodemoura @leanprover-community-mathlib4-bot