Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option tactic.customEliminators to be able to turn off custom eliminators for induction and cases #3655

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Mar 12, 2024

This was suggested by Scott Morrison to be able to help projects adjust to Nat having built-in custom eliminators.

@kmill kmill requested a review from semorrison as a code owner March 12, 2024 02:37
@kmill kmill changed the title feat: add option tactic.customEliminators to be able to turn off custom eliminators for induction and cases feat: add option tactic.customEliminators to be able to turn off custom eliminators for induction and cases Mar 12, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 12, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 12, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 12, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan full-ci labels Mar 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 12, 2024

Mathlib CI status (docs):

@semorrison semorrison added the will-merge-soon …unless someone speaks up label Mar 25, 2024
@semorrison
Copy link
Collaborator

I think we can merge after resolving the conflict in RELEASES.md. It would be good to have this in 4.8.

…stom eliminators for `induction` and `cases`

This was suggested by Scott Morrison to be able to help projects adjust to `Nat` having built-in custom eliminators.
@kmill
Copy link
Collaborator Author

kmill commented Mar 25, 2024

@semorrison Updated

@semorrison semorrison added this pull request to the merge queue Mar 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 28, 2024
Merged via the queue into leanprover:master with commit 4bacd70 Mar 28, 2024
20 checks passed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants