doc: layout algorithm #3915
Merged
doc: layout algorithm #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
digama0
commented
Apr 15, 2024
github-actions
bot
added
the
toolchain-available
|
If we're documenting access, shouldn't we also document construction? |
|
The example with access functions was mainly for demonstration purposes, to show the way offsets are used. Hopefully pointing to the existence of setter functions and saying "these are used similarly" should be sufficient. |
eric-wieser
reviewed
May 1, 2024
Kha
approved these changes
May 2, 2024
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout algorithm, while somewhat finicky, is (unfortunately) necessary for C code to interface with lean structures. This adds a (AFAIK) complete description of the layout algorithm, including a worked example large enough to make it possible to reconstruct the whole decision diagram.