Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: let Nat.mod reduce more #4145

Merged
merged 2 commits into from
May 13, 2024
Merged

refactor: let Nat.mod reduce more #4145

merged 2 commits into from
May 13, 2024

Commits on May 13, 2024

  1. refactor: Let Nat.mod reduce more 

    this refined upon #4098 and makes `Nat.mod` reduce on even more
literals. The key observation that I missed earlier is that `if m ≤ n`
reduces better than `if n < m`.

Also see discussion at
leanprover-community/mathlib4#12853 (comment)
    @nomeata
    nomeata committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e44488d View commit details
    Browse the repository at this point in the history

  2. Rename variables

    @nomeata
    nomeata committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b72fbac View commit details
    Browse the repository at this point in the history