Improve goal state display positions #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
commented
May 1, 2021
Comment on lines
+162
to
+164
| Moreover, we instruct the LSP server to use the state after the tactic execution if hoverPos >= endPos *and* | ||
| there is no nested tactic info (i.e. it is a leaf tactic; tactic combinators should decide for themselves | ||
| where to show intermediate/final states) |
There was a problem hiding this comment.
The logic for this (see below) is not quite complete yet; it doesn't work for match since there is a macro step in between, meaning you will see the final state (usually "no goals") if you put the cursor anywhere between match and =>. But it is definitely an improvement over the current state for many other tactics, in particular induction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.