fix: cdot parser error message range #4528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as #4527 describes there is inconsistency between
by
,case
andnext
on the one hand who, if the goal isn’t closed, put squigglyunderlines on the first line, and
.
, which so far only squiggled thedot (which is a very short symbol!)
With this change the same mechanism as used by
case
, namelywithCaseRef
, is also used for.
.There is an argument for the status quo: The
.
tactic is more commonly usedwith further tactics on the same line, and thus there is now a higher risk that
the user might think that the first tactic is broken. But
by
andcase
where there was an intentionalchoice to do it this way
.
is easy to miss, so it is actuallybetter to underlining more here (at least until we have a better way to
indicate incomplete proofs, which I have hopes for)
Fixes #4527, at least most of it.