Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix "max dynamic symbols" metric #4669

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: fix "max dynamic symbols" metric #4669

wants to merge 1 commit into from

Conversation

Kha
Copy link
Member

@Kha Kha commented Jul 6, 2024

As we do not build multiple shared libraries on non-Windows anymore, count the max exported symbols per static library instead. Unfortunately, this still does seem to match the number on Windows.

Kha
Kha commented Jul 6, 2024
View reviewed changes
Copy link
Member Author

@Kha Kha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!bench

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3e0ea762b831c5bc373c7486c66b80a5910fdbf2 --onto 5ad5c2cf049bea5829ccd3e72875ae375f8c422b. (2024-07-06 11:44:30)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 6, 2024 11:44 Inactive
@Kha
Copy link
Member Author

Kha commented Jul 6, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit e0eef8d.
The entire run failed.
Found no significant differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kha @leanprover-community-mathlib4-bot @leanprover-bot