Custom server request registration #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
approved these changes
Jun 15, 2021
|
Good work! |
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
I started porting logic/lemmas.lean, but found that I needed cc_lemmas.lean first. Compare to * the Lean 3 version: https://github.com/leanprover-community/lean/blob/fc13c8c72a15dab71a2c2b31410c2cadc3526bd7/library/init/cc_lemmas.lean * the lean3port version: https://github.com/leanprover-community/lean/blob/fc13c8c72a15dab71a2c2b31410c2cadc3526bd7/library/init/cc_lemmas.lean The main adjustments I needed to make were of the form `(true_iff_iff _)` -> `true_iff_iff`, because the mathlib4 version of [`true_iff_iff`](https://github.com/leanprover-community/mathlib4/blob/172bedc47e099f17a6dad47ed2bb4789c5ad1618/Mathlib/Init/Logic.lean#L192) (and similar lemmas) takes its argument implicitly, which the mathlib3 version takes it explicitly. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
For some funny reason there were aliases to lemmas from `init.cc_lemmas`, which is PR'd to mathlib4 as leanprover#532. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows registering custom LSP request handlers in the server via
builtin_initializeorinitializein plugins. We maintain a globalIO.Reftable of handlers.For now registering request handlers as-you-go in standard Lean files (via the environment) is unsupported as the semantics of that are quite unclear. In particular, the watchdog needs to know which worker to route requests to, but the
Environmentobject is only accessible within one given worker. We could require all custom requests to contain auri : DocumentUrifield. In any case I'm leaving this feature for later if it's desired.Other possible features which might be useful in the future: