Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
evalSimp
, the implementation of thesimp [...] at ...
syntax, into two functions. NowevalSimp
just handles theSyntax
parsing, whilesimpLocation
dispatches to thesimpGoal
tactic inLean.Meta.Tactic.Simp
according to alocation
argument.I want this separation so that when writing other tactics, I can invoke the simplifier using a
location
, without having to synthesize aSyntax
. (The specific application is in portingsplit_ifs
.)See also discussion on zulip.