Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/equiv/basic): generalise subtype_equiv_of_subtype #724

Merged
merged 2 commits into from Feb 14, 2019
Merged

feat(data/equiv/basic): generalise subtype_equiv_of_subtype #724

merged 2 commits into from Feb 14, 2019

Conversation

jcommelin
Copy link
Member

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@rwbarton
Copy link
Collaborator

subtype_congr a few lines later can be simplified now as well.

@johoelzl johoelzl merged commit 683519f into master Feb 14, 2019
@johoelzl johoelzl deleted the subtype_equiv branch February 14, 2019 17:04
@jcommelin
Copy link
Member Author

subtype_congr a few lines later can be simplified now as well.

Didn't see that... Can we ping some issue tracker?

@johoelzl
Copy link
Collaborator

I changed it already

@jcommelin
Copy link
Member Author

Aah, thanks!

bors bot pushed a commit that referenced this pull request Nov 30, 2022
@riccardobrasca
feat(algebra/group_with_zero/defs): add is_cancel_mul_zero (#17716)
d38fea3 
We add a class `is_cancel_mul_with_zero` (and also other related classes). This is the continuation of #17440.

Corresponding mathlib4 PR [#724](leanprover-community/mathlib4#724).
bors bot pushed a commit that referenced this pull request Nov 30, 2022
@riccardobrasca
feat(algebra/group_with_zero/defs): add is_cancel_mul_zero (#17716)
4b240be 
We add a class `is_cancel_mul_with_zero` (and also other related classes). This is the continuation of #17440.

Corresponding mathlib4 PR [#724](leanprover-community/mathlib4#724).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @rwbarton @johoelzl