Faster #391
Closed
Faster #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you PR |
|
How do I do that? |
|
I just pushed a `squeeze-simp` branch to community, that just has
squeeze_simp, without using it to speed up the library.
…On Sat, Oct 6, 2018 at 11:41 PM Kenny Lau ***@***.***> wrote:
How do I do that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdLBGGFYDeJkSoUCdTpbXYdZw3Oy9bMks5uiLMcgaJpZM4XKeZX>
.
|
|
(Kenny --- to do this I checked out the master branch, ran `git merge
--squash faster`, then threw out all the modified files except the ones in
the `tactic` directory, created a new branch, and committed.)
…On Sun, Oct 7, 2018 at 12:01 AM Scott Morrison ***@***.***> wrote:
I just pushed a `squeeze-simp` branch to community, that just has
squeeze_simp, without using it to speed up the library.
On Sat, Oct 6, 2018 at 11:41 PM Kenny Lau ***@***.***>
wrote:
> How do I do that?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#391 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAdLBGGFYDeJkSoUCdTpbXYdZw3Oy9bMks5uiLMcgaJpZM4XKeZX>
> .
>
|
kckennylau
force-pushed
the
faster
branch
3 times, most recently
from
f3153d4
to
bbf9c08
Compare
|
#396 has been merged. |
digama0
reviewed
Oct 8, 2018
algebra/group_power.lean
Outdated
| @@ -51,37 +51,39 @@ attribute [to_additive succ_smul] pow_succ | |||
| attribute [to_additive add_monoid.one_smul] pow_one | |||
|
|
|||
| theorem pow_mul_comm' (a : α) (n : ℕ) : a^n * a = a * a^n := | |||
| by induction n with n ih; simp [*, pow_succ, mul_assoc] | |||
| nat.rec_on n (by rw [pow_zero, one_mul, mul_one]) $ λ n ih, | |||
| by rw [pow_succ, mul_assoc, ih] | |||
There was a problem hiding this comment.
Don't use nat.rec_on, break out the original proof onto multiple lines or use the tac; [tac1, tac2] format
| @@ -13,6 +13,53 @@ import logic.function order.boolean_algebra | |||
|
|
|||
| open list subtype nat lattice | |||
|
|
|||
| run_cmd mk_simp_attr `multiset | |||
There was a problem hiding this comment.
Can you do this without adding a new simp set?
digama0
force-pushed
the
faster
branch
2 times, most recently
from
9842bcd
to
18b0e47
Compare
kckennylau
force-pushed
the
faster
branch
2 times, most recently
from
2083b65
to
db5de9c
Compare
|
@digama0 As I understand it, some of this is merged and some is WIP? Maybe we could close this PR and Kenny can open a new one when there's more to add? |
|
I think it's all merged except for |
|
@kckennylau, would you mind if this was closed now? |
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
For reviewers: code review check list