Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group_theory.order_of_element): subgroups of cyclic groups are cyclic #423

Merged
merged 2 commits into from
Oct 15, 2018
Merged

feat(group_theory.order_of_element): subgroups of cyclic groups are cyclic #423

merged 2 commits into from
Oct 15, 2018

Conversation

ChrisHughes24
Copy link
Member

Also fix a few theorems that had an unused fintype assumption, due to being in the wrong section.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@johoelzl johoelzl merged commit c5930f5 into leanprover-community:master Oct 15, 2018
@ChrisHughes24 ChrisHughes24 deleted the cyclic_subgroup branch October 15, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisHughes24 @johoelzl