Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(analysis/topology/banach_contraction) #428

Closed
wants to merge 2 commits into from

Conversation

rmitta
Copy link

@rmitta rmitta commented Oct 18, 2018

I think I've done all of this, the one thing I'm not sure about is whether the lemma complete_iff_seq_complete in metric_sequences is redundant.
TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@PatrickMassot
Copy link
Member

@agjftucker
Copy link
Collaborator

I have forked rmitta:Banach with an eye to updating this PR to reflect recent changes in mathlib. But now of course it doesn't compile. I think we want to rebase the branch? https://git-scm.com/book/en/v2/Git-Branching-Rebasing

@PatrickMassot
Copy link
Member

Indeed this needs rebasing first

@rmitta
Copy link
Author

rmitta commented Dec 4, 2018

Thanks for the feedback both, I've not had time for Lean for a while but I'm back on it now, should have an updated version of this in the next few days.

@agjftucker
Copy link
Collaborator

agjftucker commented Dec 4, 2018

That's great 😄. Looking back at my contribution I should mention I am using Lipschitz continuous in the Wikipedia sense rather than in the Sutherland sense (which appears to correspond to Hölder continuous on Wikipedia).
I was also thinking that for cauchy_seq (λ n, f^[n] p₀), instead of map (λ <m, n>, (f^[m] p₀, f^[n] p₀)) (filter.prod at_top at_top) ≤ uniformity, it might be nice to have map (prod.map (λ m, f^[m] p₀) (λ n, f^[n] p₀)) at_top ≤ uniformity with at_top on ℕ × ℕ derived from the natural preorder. If that makes sense.

@rmitta
Copy link
Author

rmitta commented Dec 6, 2018

I've pushed a new version of this that should compile with the latest version of mathlib and keeps the contribution by agjftucker. I had to unfortunately do some of this (the bit that I think was equivalent to rebasing) manually, but it should all work now, so I think we are good to go!

@agjftucker I didn't quite see what you were trying to say about cauchy_seq (λ n, f^[n] p₀) , do I didn't do anything about that.

open nat
def iteration_map {α : Type*} (f : α → α) (start : α) : ℕ → α
| zero := start
| (succ x) := f (iteration_map x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nat.iterate


--Definition 17.24
def is_contraction {α : Type*} [metric_space α] (f : α → α) :=
∃ (k : ℝ) (H1 : k < 1) (H2 : 0 < k), ∀ (x y : α), dist (f x) (f y) ≤ k* (dist x y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put some more space in, I was wondering what the k* function is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is yet ready to review. Between Rohan Mitta and myself we have a lot of redundancy. There is a completely parallel proof of the main theorem here https://github.com/agjftucker/mathlib/blob/Banach/analysis/topology/banach_contraction.lean

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have said: it would be great to have your feedback :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, remove the [WIP] when ready

@digama0 digama0 changed the title feat(analysis/topology/banach_contraction) [WIP] feat(analysis/topology/banach_contraction) Dec 17, 2018
@johoelzl
Copy link
Collaborator

closed with #553

@johoelzl johoelzl closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants