Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ext #506

Closed
Closed

Conversation

cipher1024
Copy link
Collaborator

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@cipher1024 cipher1024 force-pushed the fix-ext branch 3 times, most recently from 5763470 to 0993c5c Compare December 2, 2018 00:47
@cipher1024 cipher1024 force-pushed the fix-ext branch 3 times, most recently from da1f829 to ff3eaf8 Compare December 5, 2018 19:58
@cipher1024
Copy link
Collaborator Author

@digama0 Can you clear Travis' cache and restart the build please?

@johoelzl
Copy link
Collaborator

There is no documentation of the changes. Can you change the documentation for ext?

@cipher1024 cipher1024 self-assigned this Feb 2, 2019
@robertylewis
Copy link
Member

I missed this yesterday. @cipher1024 is this still active? What is it fixing? Is this still WIP, or done, or can it be closed?

@robertylewis
Copy link
Member

I'm going to close this for now. Please reopen and mark as WIP if you plan to come back to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants