Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: de-mathlib Data/List/Pairwise.lean #100

Conversation

JamesGallicchio
Copy link
Collaborator

@JamesGallicchio JamesGallicchio commented Feb 1, 2023

All included statements are the same as mathlib4, but a good number of lemmas are dropped. See diff.

Depends on #99 #95.

@JamesGallicchio JamesGallicchio force-pushed the chore/move-Data/List/Pairwise.lean branch from 7415add to 634bfc1 Compare February 1, 2023 18:15
@JamesGallicchio JamesGallicchio marked this pull request as ready for review February 1, 2023 18:38
@JamesGallicchio JamesGallicchio force-pushed the chore/move-Data/List/Pairwise.lean branch 2 times, most recently from 128d0a5 to 79d844f Compare June 27, 2023 05:21
@kim-em kim-em added merge conflict depends on another PR This is stacked on top of another Batteries PR. labels Aug 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Aug 21, 2023
@JamesGallicchio JamesGallicchio marked this pull request as draft August 22, 2023 06:41
@JamesGallicchio JamesGallicchio force-pushed the chore/move-Data/List/Pairwise.lean branch from 79d844f to 79fcee4 Compare August 23, 2023 02:36
@JamesGallicchio JamesGallicchio force-pushed the chore/move-Data/List/Pairwise.lean branch from 79fcee4 to b580038 Compare August 23, 2023 02:41
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Aug 23, 2023
@JamesGallicchio JamesGallicchio removed the depends on another PR This is stacked on top of another Batteries PR. label Aug 23, 2023
@JamesGallicchio JamesGallicchio marked this pull request as ready for review August 23, 2023 03:55
@JamesGallicchio JamesGallicchio added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 26, 2023
@JamesGallicchio
Copy link
Collaborator Author

Looks good to me. See leanprover-community/mathlib4#6743 for the mathlib changes.

@kim-em
Copy link
Collaborator

kim-em commented Aug 28, 2023

I think based on the Mathlib PR being painless, this should be safe to merge.

@digama0 digama0 merged commit 32c1912 into leanprover-community:main Sep 17, 2023
1 check passed
@Vtec234 Vtec234 deleted the chore/move-Data/List/Pairwise.lean branch September 17, 2023 21:12
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 18, 2023
Std bump patch for leanprover-community/batteries#100


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kodyvajjha pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 22, 2023
Std bump patch for leanprover-community/batteries#100


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants