-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Data.Fin.Lemmas <- mathlib #173
Conversation
What kind of assistance do you require? |
It's basically unfinished work, I made it about 1/4 of the way through the file. The task here is to remove anything referencing mathlib notions like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom recursors work better when the hypotheses have predictable and meaningful names. This is to facilitate the use of the pattern induction x using foo with | hyp ... => ...
I went through and recommended better names.
PS: Also consider using motive
instead of C
but I don't think that's essential.
The de-ord-embedding/iso-ification seems like it was done right, so here's a 👍 from me, though I only checked about 400-500 lines in detail |
- [x] depends on: leanprover-community/batteries#163 - [x] depends on: #5584 - [x] depends on: #5715 - [x] depends on: #5729 - [x] depends on: leanprover-community/batteries#173 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) Co-authored-by: Komyyy <pol_tta@outlook.jp> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com>
- [x] depends on: leanprover-community/batteries#163 - [x] depends on: #5584 - [x] depends on: #5715 - [x] depends on: #5729 - [x] depends on: leanprover-community/batteries#173 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) Co-authored-by: Komyyy <pol_tta@outlook.jp> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com>
- [x] depends on: leanprover-community/batteries#163 - [x] depends on: #5584 - [x] depends on: #5715 - [x] depends on: #5729 - [x] depends on: leanprover-community/batteries#173 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) Co-authored-by: Komyyy <pol_tta@outlook.jp> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com>
A WIP branch for porting Mathlib.Data.Fin.Basic to std.