chore: upstream the once-per-file Cache for tactics #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
the
awaiting-review
fgdorais
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Using choice is mostly harmless but it is best to avoid it since Std is intended for computation. In core, it's mostly used to get excluded middle, which only affects Prop so it's essentially harmless for computation. The use here is in an actual type so potentially not so harmless.
fgdorais
approved these changes
Aug 20, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Great! Another dependency of I had a PR against that file in mathlib4, at leanprover-community/mathlib4#7384. Should I port this against std4 now, or is that PR unwanted anyways? I’ll just open the PR at #346 |
nomeata
reviewed
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another component of
exact?that will need to be upstreamed.