Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore functionality to offer to install elan #111

Merged
merged 1 commit into from Feb 1, 2019

Conversation

semorrison
Copy link
Contributor

No description provided.

@bryangingechen
Copy link
Contributor

The idea behind setting hasLean = true there was to prevent the "install elan" dialogue from popping up unnecessarily (see #95). Ideally it should be at the first location in the code which is unreachable unless a working copy of lean is present (for example, I had thought that if there was no working lean, then by this point execution will have passed to the catch block). Where it is now seems to be too early since it prevents the dialog from ever showing up. It could be that this is the wrong approach entirely, but if not, can you check to see if putting that line later on in that block works better?

@gebner gebner merged commit 7a8b030 into leanprover:master Feb 1, 2019
@gebner
Copy link
Member

gebner commented Feb 1, 2019

Merging this now since I'm going on vacation tomorrow. Feel free to submit another PR that fixes this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants