Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paths relative to the extension path in lean.executableP… #134

Merged
merged 3 commits into from Jan 5, 2020

Conversation

bryangingechen
Copy link
Contributor

Per @PatrickMassot's request here, this PR adds the ability to use a special token (currently %extensionPath%) in the two path settings lean.executablePath and lean.leanpkgPath which is replaced by the absolute path to the extension directory.

Happy to change the syntax, I basically used the first thing that came to mind!

Other changes:

  • In 7ad69c4 fixes a possible typo; I saw a line in leanpkg.ts which returns a path ending in lean instead of leanpkg.
  • I updated the instructions for the leanpkg integration in the README; previously it said ctrl+p, but this only opens the file search menu. I changed it to ctrl+shift+p.

The token '%extensionPath%' can be used in the configuration
settings lean.executablePath and lean.leanpkgPath. It is replaced
by the absolute path to the extension. This could be useful for
specifying the path to lean and leanpkg in portable installations.
@gebner gebner changed the title Support paths relative to the extension path in lean.executablePath and lean.leanpkgPath Support paths relative to the extension path in lean.executableP… Jan 5, 2020
@gebner gebner merged commit 54906f7 into leanprover:master Jan 5, 2020
@bryangingechen bryangingechen deleted the pmassot branch February 9, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants