Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loading animation at unitScreen centered #157

Merged
merged 1 commit into from Nov 2, 2022
Merged

loading animation at unitScreen centered #157

merged 1 commit into from Nov 2, 2022

Conversation

maliyildiz1
Copy link
Member

#110 fixed

@maliyildiz1 maliyildiz1 self-assigned this Oct 27, 2022
@maliyildiz1 maliyildiz1 linked an issue Oct 27, 2022 that may be closed by this pull request
UnitScreen loading animation not centered #110
Closed
turndownfawad
turndownfawad approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@turndownfawad turndownfawad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url changes done to app.json and settings.json could be undone to have less changes since they don't contribute to the actual issue, however so far it looks fine.

@jankapunkt jankapunkt merged commit 6b8ade1 into main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankapunkt jankapunkt jankapunkt approved these changes

@turndownfawad turndownfawad turndownfawad approved these changes

Assignees

@maliyildiz1 maliyildiz1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnitScreen loading animation not centered
3 participants
@maliyildiz1 @jankapunkt @turndownfawad