-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement minimal routes #11
Conversation
… Routes from Router
@tushar13293 I added you as a reviewer for this PR. This is basically the foundation for you to work with this app. Please checkout this branch via
If there is any issue in the code you don't understand, please use the review to add comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, this is because the OAuth workflow logs you in across apps, so if you log out from the teacher app you are not finally logged out. But for teachers we should implement a logout call to the OAuth server so they are 100% logged out. This however requires this first to be solved in the accounts application. Since you found nothing else I will merge this now and create the respective issues. Thank you 👍 |
This PR implements #1 by creating all required minimal routes
Status: