Refactor #78
Refactor #78
Conversation
| import "./TxLib.sol"; | ||
| import "./PriorityQueue.sol"; | ||
|
|
||
| contract ExitHandler is DepositHandler { |
There was a problem hiding this comment.
This looks strange from OOP point of view
There was a problem hiding this comment.
OOP would be something like:
Vault <- DepositableVault <- ExitableVault
?
There was a problem hiding this comment.
Since we have multiple inheritance it can be Vault ← DepositableVault & ExitableVault. But it's really a nitpicking :-) I know too few about solidity to have a voice here
There was a problem hiding this comment.
Makes sense. The most reasonable relationship would be to have a composition I guess, that is a Vault has a DepositHandler and it has an ExitHandler.
There was a problem hiding this comment.
But we will need a separate exit procedure for unincluded deposits so we will need a version of ExitHandler that is aware of the deposits.
There was a problem hiding this comment.
As i said, you can ignore me here :-)
No description provided.