Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Burner wallet page needs to be refreshed from time to time #67

Open
eshavkun opened this issue Apr 25, 2019 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@eshavkun
Copy link

This happens only on mobile browsers.
If user leaves page/browser with Burner opened for a while on background without touching it, the buttons stop working and main (ETH) network balance shows as 0 even when it's not (plasma balance is shown correctly). User needs to refresh the page to make wallet working again.
It may be caused by websockets timeout

@eshavkun eshavkun added the bug Something isn't working label Apr 25, 2019
@TimDaub
Copy link
Collaborator

TimDaub commented May 13, 2019

@artico wrote on slack:

don't you know why burner wallet constantly makes thousands of requests to dai.poa.network? any practical reason? it even crushes my browser sometimes...

https://leapdao.slack.com/archives/CHBFMQ526/p1557510409001300

I think these two observations are connected.

Adding this to the sprint.

Scope

  • The burner wallet makes an excessive amount of requests when opened. This is makes it behave non-responsive in some cases
  • Additionally Chrome throws the following message: MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 data listeners added.

Deliverables

  • Reduce the amount of connections and requests the burner-wallet establishes

Gain for the project

  • Increased performance of the burner-wallet increases the user's experience
  • Reduces load on leap-nodes

Roles

bounty gardener:@TimDaub / 15%
bounty worker: name / 75%
bounty reviewer: name / 10%

@iamonuwa
Copy link
Member

Wow! Since June and I forgot about this 🙈. Let me investigate it and work on it now

@MaxStalker
Copy link
Member

@iamonuwa Actually, I would recommend not to invest your time into it (unless you really want it). First of all - there is no bounty on this issue anymore. Second, we probably gonna move away from BW v1 in favor for v2 in near future.

@iamonuwa
Copy link
Member

Since we are moving. I'll move on to where the need is greater. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants