Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create On-Chain Executor #3

Closed
johannbarbie opened this issue Jul 13, 2018 · 7 comments
Closed

Create On-Chain Executor #3

johannbarbie opened this issue Jul 13, 2018 · 7 comments
Labels
bounty enhancement New feature or request

Comments

@johannbarbie
Copy link
Member

johannbarbie commented Jul 13, 2018

The on-chain executor calls the initAndRun() method as transaction (needs to fit into block gas limit), but executes only 1 step:

  • Have the EVM load at a given step of some program, execute the current OP-code, and return the state of the EVM (at next step).
  • Implement unit tests for each OP-code in the following way:
    1. Run off-chain EVM and export state at steps x and x+1.
    2. Load on-chain EVM with step x, run 1 step, and compare with x+1 from off-chain.
    3. Implement tests where x falls on every possible Op-code (see list in architecture docs, except extra difficult).

This implementation will give us the confidence that the on-chain executor produces the same results as the off-chain executor.

@johannbarbie johannbarbie added the enhancement New feature or request label Jul 13, 2018
@troggy troggy added the bounty label Jul 26, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 7.07 ETH (1349.79 USD @ $190.92/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Sep 11, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 4 hours from now.
Please review their action plans below:

1) troggy has been approved to start work.

Extend my work on Off-Chain executor to use the state from stopped execution

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@troggy Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vs77bb
Copy link

vs77bb commented Sep 14, 2018

Hi @troggy you still working on this one? We know you, so snoozing Gitcoin Bot here for 5 days in good faith 🙌

@troggy
Copy link
Member

troggy commented Sep 17, 2018

ah.. yeah. Got to create WIP PR. @vs77bb thanks for the poking :)

@troggy troggy mentioned this issue Sep 18, 2018
2 tasks
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 7.07 ETH (1608.25 USD @ $227.48/ETH) has been submitted by:

  1. @troggy

@johannbarbie please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 7.07 ETH (1564.82 USD @ $221.33/ETH) attached to this issue has been approved & issued to @troggy.

@troggy troggy closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants