-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: updating the validations API #8
Conversation
Thank you @paganotoni this looks good to me |
@tatang26 I'll continue giving this shape. |
docs/features/validations.md
Outdated
Validations are a set of rules stablished for different fields passed in the request. You can define these Validations to be used in your http handlers by and call the `form.Validate` function passing the `req` (*http.Request) and handling the `validate.Errors` returned. Example: | ||
|
||
```go | ||
newUserValidation := validate.Form{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tatang26 take a look at this. This is where I'm landing.
docs/features/validations.md
Outdated
Validations are a set of rules stablished for different fields passed in the request. You can define these Validations to be used in your http handlers by and call the `form.Validate` function passing the `req` (*http.Request) and handling the `validate.Errors` returned. Example: | ||
|
||
```go | ||
newUserValidation := validate.Form( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,69 +1,54 @@ | |||
package validation | |||
package validate_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tatang26 I would like to rewrite these as they repeat a lot of things.
cc @tatang26