Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RiggedFinger script uses GetBoneCenter erroneously #143

Open
jo3w4rd opened this issue Oct 21, 2015 · 0 comments
Open

RiggedFinger script uses GetBoneCenter erroneously #143

jo3w4rd opened this issue Oct 21, 2015 · 0 comments
Labels

Comments

@jo3w4rd
Copy link
Contributor

jo3w4rd commented Oct 21, 2015

When FingerModel.deformPosition is set to true, the RiggedFinger script gets the bone center position and moves the bone to this position. This is incorrect since bones pivot around their proximal joint (Bone.prevJoint), not the center point between two joints.

The GetBoneCenter() function is used in non-rigged hand scripts as well, so a new function will be needed to correct this problem.

An easy way to observe the problem is to set deformPosition to true on one of the standard rigged hand prefabs. Using the GetBoneCenter() function, the hands are webbed and arthritic. Replacing bone center with the previous joint position makes things look much better.

@Anvil102 Anvil102 added the bug label Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants