Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode deprecation warning for OSMemoryBarrier() #1010

Merged
merged 1 commit into from Oct 27, 2016
Merged

Conversation

jdonald
Copy link
Contributor

@jdonald jdonald commented Oct 26, 2016

Fix this warning in autoboost :

autowiring/contrib/autoboost/autoboost/asio/detail/macos_fenced_block.hpp:51:5: warning: 
      'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use
      std::atomic_thread_fence() from <atomic> instead
      [-Wdeprecated-declarations]
    OSMemoryBarrier();

Doesn't seem to be fixed in the boost repo yet so I couldn't mimic something there.

On github I found in the repo for cmus, a music player, they used std::memory_order_seq_cst. The documentation seems to indicate OSMemoryBarrier() is a sequential consistency barrier too.

@jdonald jdonald added this to the v1.0.4 milestone Oct 26, 2016
@hham hham self-assigned this Oct 27, 2016
@hham hham merged commit 5e1ec35 into master Oct 27, 2016
@hham hham deleted the fix-xcode8-warning branch October 27, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants