Fix parallel class #1030

gittyupagain · 2017-10-31T17:48:14Z

Threads were leaking due to DispatchQueue::WaitForEvent waiting forever for each thread. The fix was to Rundown the dispatch queue, causing WaitForEvent to abort both existing and future calls.

jdonald · 2017-10-31T18:16:27Z

src/autowiring/Parallel.cpp

+  auto block = m_block;
+  if (!block)
+    return;
+  std::lock_guard<std::mutex> lk(block->m_lock);


Jonathan Marsden added 2 commits October 31, 2017 10:17

Rundown the dispatch queue, allowing all threads to finish

241b058

No need for owner check; all threads will exit due to Rundown

e42c9b5

gittyupagain added the bug label Oct 31, 2017

gittyupagain requested a review from jdonald October 31, 2017 17:48

jdonald reviewed Oct 31, 2017

View reviewed changes

src/autowiring/Parallel.cpp

auto block = m_block;

if (!block)

return;

std::lock_guard<std::mutex> lk(block->m_lock);

Copy link

Contributor

jdonald Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jdonald merged commit ed02b38 into master Oct 31, 2017

jdonald deleted the fix-parallel branch October 31, 2017 19:05

jdonald added this to the v1.0.5 milestone Oct 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix parallel class #1030

Fix parallel class #1030

gittyupagain commented Oct 31, 2017

jdonald Oct 31, 2017

Fix parallel class #1030

Fix parallel class #1030

Conversation

gittyupagain commented Oct 31, 2017

jdonald Oct 31, 2017

Choose a reason for hiding this comment