Remove support for auto_prev #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdonald
approved these changes
Mar 9, 2018
yeswalrus
approved these changes
Mar 9, 2018
|
We'll need to bump AW to at least 1.1 after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
auto_prevfeature was added to Autowiring with the intention of being able to automatically use AutoFilter decorations from one packet in the next packet. Unfortunately, we often found that there were performance penalties for doing so. It ended up being easier, and faster, to just keep a reference to the shared object if needed. Due to its issues, any references to usingauto_previn AutoFilters were removed from our applications.The actual implementation of
auto_prevrelies on having successor links between the packets. This also means that any long-running packet will keep around all newer packets, even those that have completed, until the oldest remaining packet has completed.In addition to removing the
auto_prevfeature, this PR also removes the time-shifted decoration concept, and any successor logic that links the packets together.