Recursively call CoreContext::Stop before waiting on anything
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
fix-unintendedwait
branch
5 times, most recently
from
9d30afa
to
11dd31d
Compare
This change ensures that all members of the current context receive an `OnStop` message before a wait is triggered on child contexts. It's also gradually becoming clear that it may be necessary to deprecate `SignalShutdown(true)` as a typical calling convention. We should probably require users to manually call `Wait` if that's what they want to do.
codemercenary
force-pushed
the
fix-unintendedwait
branch
from
11dd31d
to
51982e3
Compare
gittyupagain
pushed a commit
that referenced
this pull request
Mar 24, 2015
Recursively call `CoreContext::Stop` before waiting on anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all members of the current context receive an
OnStopmessage before a wait is triggered on child contexts.It's also gradually becoming clear that it may be necessary to deprecate
SignalShutdown(true)as a typical calling convention. We should probably require users to manually callWaitif that's what they want to do.